-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a multi-dim add layer test. #10437
Conversation
// It seems tensorrt FC use col-major: [[1.0, 3.3], [1.1, 4.4]] | ||
// instead of row-major, which is [[1.0, 1.1], [3.3, 4.4]] | ||
float raw_weight[4] = {1.0, 1.1, 3.3, 4.4}; | ||
// [1, 2] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
请问85行的注释需要删掉或者进行下补充么?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The teamcity fails (fix in #10420), you can merge the latest code.
We need to figure out if tensorrt use row-major or col-major for tensor layerout inorder to do conversion.
This PR is ready @luotao1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We need to figure out if tensorrt
use row-major or col-major for tensor
layeout inorder to do conversion.
tensorrt doc says its row-major, but in my test, it seems to be col-major